RFR: 8298524: Debug function to trace reachability of CDS archived heap objects [v2]

Ioi Lam iklam at openjdk.org
Mon Dec 12 22:22:26 UTC 2022


On Mon, 12 Dec 2022 19:58:08 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @calvinccheung comments -- removed outdated comment
>
> src/hotspot/share/cds/cdsHeapVerifier.cpp line 278:
> 
>> 276: 
>> 277: // Hint: to exercise this function, uncomment out one of the ADD_EXCL lines above.
>> 278: int CDSHeapVerifier::trace_to_root(outputStream* st, oop orig_obj, oop orig_field, HeapShared::CachedOopInfo* info) {
> 
> With this change, this function could also be exercised via a debugger. Should the comment be updated?

Thanks for the review. Since the comment a few lines above here mentions gdb, this comment is out-dated, so I deleted it in the latest commit.

-------------

PR: https://git.openjdk.org/jdk/pull/11628


More information about the hotspot-runtime-dev mailing list