RFR: 8298730: Refactor subsystem_file_line_contents and add docs and tests

Severin Gehwolf sgehwolf at openjdk.org
Wed Dec 14 13:40:48 UTC 2022


On Wed, 14 Dec 2022 12:56:59 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp line 115:
>> 
>>> 113:   return os::strdup(mems);
>>> 114: }
>>> 115: 
>> 
>> This seems a no-op change, please remove from the patch.
>
> This puts `cpu_period` and `cpu_quota_val` next to each other, as they both read from `cpu.max` in opposite order (`"%*s %d"` and `"%1023s %*d"`). I think it improves readability, as it's not obvious why `%*d` is there otherwise. Still remove?

Yes please, it's got nothing to do with this change. Feel free to move it in separate RFE.

-------------

PR: https://git.openjdk.org/jdk/pull/11667


More information about the hotspot-runtime-dev mailing list