RFR: 8281946: VM.native_memory should report size of shareable memory [v3]

Matias Saavedra Silva matsaave at openjdk.org
Thu Dec 15 04:30:06 UTC 2022


On Tue, 6 Dec 2022 20:55:30 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>>> We should instead just use MAP_SHARED flag for ro sections.
>> 
>> To clarify, if the ro sections don't require relocation, use MAP_SHARED, else use MAP_PRIVATE.
>
>> > We should instead just use MAP_SHARED flag for ro sections.
>> 
>> To clarify, if the ro sections don't require relocation, use MAP_SHARED, else use MAP_PRIVATE.
> 
> I am not sure why we use MAP_PRIVATE + PROT_READ for CDS. Maybe it just happened to work so we end up doing it that way. I filed https://bugs.openjdk.org/browse/JDK-8298216 , quoting your suggestions from the previous comments.

Thank you for your patience and reviews @iklam and @tstuefe! I re-ran tier1 tests and the macos-x64 tests pass, so I think we can safely ignore GHA here.

-------------

PR: https://git.openjdk.org/jdk/pull/11401


More information about the hotspot-runtime-dev mailing list