RFR: JDK-8298852: Use of uninitialized memory in MetadataFactory::free_metadata

[David Holmes]

On Thu, 15 Dec 2022 10:19:05 GMT, Justin King <jcking at openjdk.org> wrote:

> Fix undefined behavior by shifting call to member function to before destructor is called. Upon the destructor being called, the contents of the object are considered uninitialized and reading them is undefined.

Fix looks good. This was in the original variant that @jcking put together, but got overlooked in @coleenp 's version.

Definitely needs to be backported. Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11688