RFR: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected

[Severin Gehwolf]

On Tue, 20 Dec 2022 00:03:25 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> I am removing this test scenario for now as I don't see it providing any actual value.

I disagree. It seems useful in the docker/container case as there are APIs in the JDK reporting those metrics and it wouldn't be tested otherwise.

Note that this test is also being used by `TestSystemMetrics.java`. Entrypoint in the `TestSystemMetrics` case is `main()` (over entrypoint `testAll()` via `TestCgroupMetrics`).

> If we want to have more in-depth functional tests for the `Metrics.getMemoryXXX()` APIs, we need to do it inside a container in a more controlled setting.

That's what the above mentioned `TestSystemMetrics.java` does. I take it that test is not problematic? If so, we should just not invoke `testMemoryUsage()` when invoked from `TestCgroupMetrics`.

-------------

PR: https://git.openjdk.org/jdk/pull/11734