RFR: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Thu Dec 22 09:19:49 UTC 2022
On Wed, 21 Dec 2022 20:49:24 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> The `testMemoryUsage()` test scenario queries the total memory usage of all processes of the current Linux user, including other concurrently running jtreg test cases. Even if the current process allocates 256MB of ram, it's possible for other dying processes to release much more than that amount. Therefore, it's not possible to guarantee that `Metrics.getMemoryUsage()` would return a higher number.
>>
>> I am removing this test scenario for now as I don't see it providing any actual value.
>>
>> If we want to have more in-depth functional tests for the `Metrics.getMemoryXXX()` APIs, we need to do it inside a container in a more controlled setting.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>
> @jerboaa comments -- disable memory metric tests only when running outside of container
Looks good, thanks!
-------------
Marked as reviewed by sgehwolf (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11734
More information about the hotspot-runtime-dev
mailing list