RFR: 8298601: Refactor archiving of java.lang.Module objects [v2]
Ioi Lam
iklam at openjdk.org
Thu Dec 22 21:50:06 UTC 2022
On Tue, 20 Dec 2022 13:47:13 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review from @coleenp and @calvinccheung
>
> src/hotspot/share/classfile/moduleEntry.cpp line 523:
>
>> 521:
>> 522: #ifndef PRODUCT
>> 523: void ModuleEntry::validate_archived_module_entries() {
>
> Can this have a check_module_entries name since it's called by a similarly sounding function name in Modules? It doesn't actually validate anything in the module entries except the count.
I renamed it to `ModuleEntry::verify_archived_module_entries()` to be consistent with `Modules::verify_archived_modules()`.
-------------
PR: https://git.openjdk.org/jdk/pull/11715
More information about the hotspot-runtime-dev
mailing list