RFR: 8299343: Windows: Invalid thread_native_entry declaration

David Holmes dholmes at openjdk.org
Mon Dec 26 08:00:49 UTC 2022


On Sun, 25 Dec 2022 01:19:29 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to the Windows version of thread_native_entry.  It
> is changed from being inconsistently declared (both file-scoped and external)
> to consistently being a private static member function in os::win32.  It's
> signature is also changed to match where it's used, eliminating the need for a
> function pointer cast.
> 
> Testing:
> mach5 tier1

Why do we want/need this to be a C++ static member function? The thread entry points are always plain C functions.

-------------

PR: https://git.openjdk.org/jdk/pull/11787


More information about the hotspot-runtime-dev mailing list