RFR: 8280767: -XX:ArchiveClassesAtExit does not archive BoundMethodHandle$Species classes [v2]

Yumin Qi minqi at openjdk.java.net
Thu Feb 3 22:26:57 UTC 2022


> Hi, Please review
> 
>   When do dynamic dump, the call to LambdaForInvolkers::append_filtered for generating lambda holder classes will only allow the result which matches the filtering list to be added . This filters out the SPECIES method handle holder classes, and they won't be archived in dynamic shared archive. The patch is doing followings:
>   1) Removed the call to  LambdaForInvolkers::append_filtered, instead just call LambdaForInvolkers::append so the SPECIES can be added to the regeneration list.
>   2) Added an enum for  shared flag in Klass, _generated to indicate the class is regenerated and it should not be loaded from CDS if CFLH is enabled. If the class is a SPECIES and also loaded from base archive, skip regenerating it for dynamic archive.
>   3) Removed SystemDictionaryShared::is_hidden_lambda_proxy since it is only used in one place where checking CFLH  --- moved the checking code into KlassFactory::check_shared_class_file_load_hook to make code cleaner.
> 
> Tests: tier1,tier4
> 
> Thanks
> Yumin

Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:

  Avoid call CFLH for regenerated lambda holder classes, reversed change for is_hidden_lambda_proxy

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7329/files
  - new: https://git.openjdk.java.net/jdk/pull/7329/files/52099534..8f1d356c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7329&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7329&range=00-01

  Stats: 30 lines in 4 files changed: 19 ins; 6 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7329.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7329/head:pull/7329

PR: https://git.openjdk.java.net/jdk/pull/7329


More information about the hotspot-runtime-dev mailing list