RFR: 8272807: Permit use of memory concurrent with pretouch

Thomas Stuefe stuefe at openjdk.java.net
Fri Feb 4 12:31:09 UTC 2022


On Fri, 4 Feb 2022 12:21:43 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> src/hotspot/share/runtime/os.cpp line 1758:
>> 
>>> 1756: void os::pretouch_memory(void* start, void* end, size_t page_size) {
>>> 1757:   assert(is_power_of_2(page_size), "page size misaligned: %zu", page_size);
>>> 1758:   assert(page_size >= sizeof(int), "page size too small: %zu", page_size);
>> 
>> `SIZE_FORMAT` instead of `%zu`.
>
> `%zu` is C99 Standard, so also available in C++14.  It's also long been supported by gcc in C++03 mode, and by at least VS2015 and later. See https://bugs.openjdk.java.net/browse/JDK-8256379.  There's been no effort to go back and change existing code, but it's been getting used in new code for a while.

So, do you use that also for UINTX_FORMAT?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7343


More information about the hotspot-runtime-dev mailing list