RFR: 8280767: -XX:ArchiveClassesAtExit does not archive BoundMethodHandle$Species classes [v3]

[Calvin Cheung]

On Fri, 4 Feb 2022 15:44:47 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Hi, Please review
>> 
>>   When do dynamic dump, the call to LambdaForInvolkers::append_filtered for generating lambda holder classes will only allow the result which matches the filtering list to be added . This filters out the SPECIES method handle holder classes, and they won't be archived in dynamic shared archive. The patch is doing followings:
>>   1) Removed the call to  LambdaForInvolkers::append_filtered, instead just call LambdaForInvolkers::append so the SPECIES can be added to the regeneration list.
>>   2) Added an enum for  shared flag in Klass, _generated to indicate the class is regenerated and it should not be loaded from CDS if CFLH is enabled. If the class is a SPECIES and also loaded from base archive, skip regenerating it for dynamic archive.
>>   3) If CFLH is enabled, for regenerated classes, avoid calling CFLH.
>> 
>> Tests: tier1,tier4
>> 
>> Thanks
>> Yumin
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed comment

Looks good. Please add a comment in the test case.

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestLambdaInvokers.java line 60:

> 58:              mainClass)
> 59:              .assertNormalExit(output -> {
> 60:                  output.shouldContain("java.lang.invoke.BoundMethodHandle$Species_JL source: shared objects file (top)");

Please add a comment indicating the "species" class is from the "CDSLambdaInvoker" test program.

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7329