RFR: 8281314: Rename Stack{Red,Yellow,Reserved,Shadow}Pages multipliers [v2]

[Aleksey Shipilev]

On Mon, 7 Feb 2022 15:44:36 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/share/runtime/stackOverflow.cpp line 45:
>> 
>>> 43:   // in 4K pages to the actual os page size. We must do this before setting
>>> 44:   // up minimal stack sizes etc. in os::init_2().
>>> 45:   size_t unit = 4*K;
>> 
>> I think we picked 4*k because it was the smallest page size in the platforms that we supported. I might be wrong about that but the name 'unit' should be something else indicative of why it's 4k.
>
> I was thinking that the `globals.hpp` use it in a unit-like fashion: "Number of yellow zone (recoverable overflows) pages of size 4KB". In other words, that 4K is forced by option definition. I could add a blurb to the comment itself, about the motivation for this oddity.

...like in the new commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7362