RFR: JDK-8281274: deal with ActiveProcessorCount in os::Linux::print_container_info [v3]

Severin Gehwolf sgehwolf at openjdk.java.net
Mon Feb 7 16:19:10 UTC 2022


On Mon, 7 Feb 2022 14:34:34 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> The function os::Linux::print_container_info outputs memory- and cpu-related container information (when running in a containerized environment).
>> However in the case of active processor count , it currently just outputs the info from OSContainer::active_processor_count without  looking at  ActiveProcessorCount that can be set to overwrite the OSContainer::active_processor_count() - information. This should be improved.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust output again, adjust test

Changes requested by sgehwolf (Reviewer).

test/hotspot/jtreg/containers/docker/TestMisc.java line 89:

> 87:         Common.logNewTestCase("Test print_container_info()");
> 88: 
> 89:         DockerRunOptions opts = Common.newOpts(imageName, "PrintContainerInfo", "-XX:ActiveProcessorCount=2");

It would be better to separate this specific test. More like this:
https://github.com/jerboaa/jdk/commit/3911ef81c8f280a2c0da259211b91f4c3e8c3994

-------------

PR: https://git.openjdk.java.net/jdk/pull/7354


More information about the hotspot-runtime-dev mailing list