RFR: 8281314: Rename Stack{Red,Yellow,Reserved,Shadow}Pages multipliers [v3]
Coleen Phillimore
coleenp at openjdk.java.net
Mon Feb 7 19:03:11 UTC 2022
On Mon, 7 Feb 2022 16:09:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> This was a question during [JDK-8072070](https://bugs.openjdk.java.net/browse/JDK-8072070) review. The code in `StackOverflow::initialize_stack_zone_sizes()` multiplies `Stack{Red,Yellow,Reserved,Shadow}Pages` by "alignment", while that is actually just a "unit".
>>
>>
>> product_pd(intx, StackYellowPages, \
>> "Number of yellow zone (recoverable overflows) pages of size " \
>> "4KB. If pages are bigger yellow zone is aligned up.") \
>> range(MIN_STACK_YELLOW_PAGES, (DEFAULT_STACK_YELLOW_PAGES+5)) \
>>
>>
>> We can rename it for clarity.
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
> Typo
Approved and this is trivial.
-------------
Marked as reviewed by coleenp (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7362
More information about the hotspot-runtime-dev
mailing list