RFR: 8281195: Mistakenly used logging causes significant overhead in interpreter [v2]

[Coleen Phillimore]

On Mon, 7 Feb 2022 17:43:51 GMT, Alexey Pavlyutkin <duke at openjdk.java.net> wrote:

>> Fixes
>> 
>> `bool OopMapCacheEntry::verify_mask(CellTypeState* vars, CellTypeState* stack, int max_locals, int stack_top)`
>> 
>> eliminating frequent generation of log messages with no respect of logging configuration
>> 
>> Verification: N/A (the issue does not have an observable effect)
>> 
>> Regression: hotspot_compiler (20.04 on amd64 )
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing per review

src/hotspot/share/interpreter/oopMapCache.cpp line 282:

> 280:   LogStream st(Log(interpreter, oopmap)::trace());
> 281: 
> 282:   if (log) st.print("Locals (%d): ", max_locals);

This seems unfortunate to have these if statements, and a counter goal of the logging framework.  Is there another way to do this without the if statements?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7367