RFR: 8281195: Mistakenly used logging causes significant overhead in interpreter [v4]

David Holmes dholmes at openjdk.java.net
Tue Feb 8 07:16:09 UTC 2022


On Tue, 8 Feb 2022 06:39:33 GMT, Alexey Pavlyutkin <duke at openjdk.java.net> wrote:

>> Fixes
>> 
>> `bool OopMapCacheEntry::verify_mask(CellTypeState* vars, CellTypeState* stack, int max_locals, int stack_top)`
>> 
>> eliminating frequent generation of log messages with no respect of logging configuration
>> 
>> Verification: N/A (the issue does not have an observable effect)
>> 
>> Regression: hotspot_compiler (20.04 on amd64 )
>
> Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restores mistakenly lost code

Sorry but I really object to the code duplication here.

I guess we need a third opinion. :)

David

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7367


More information about the hotspot-runtime-dev mailing list