Integrated: 8281314: Rename Stack{Red,Yellow,Reserved,Shadow}Pages multipliers

Aleksey Shipilev shade at openjdk.java.net
Tue Feb 8 07:23:09 UTC 2022


On Mon, 7 Feb 2022 07:27:13 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> This was a question during [JDK-8072070](https://bugs.openjdk.java.net/browse/JDK-8072070) review. The code in `StackOverflow::initialize_stack_zone_sizes()` multiplies `Stack{Red,Yellow,Reserved,Shadow}Pages` by "alignment", while that is actually just a "unit".
> 
> 
>   product_pd(intx, StackYellowPages, \
>           "Number of yellow zone (recoverable overflows) pages of size " \
>           "4KB. If pages are bigger yellow zone is aligned up.") \
>           range(MIN_STACK_YELLOW_PAGES, (DEFAULT_STACK_YELLOW_PAGES+5)) \
> 
> 
> We can rename it for clarity.

This pull request has now been integrated.

Changeset: 4eacacb5
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/4eacacb5ad61020c11a521111c40af9fa72e2ff5
Stats:     9 lines in 1 file changed: 1 ins; 0 del; 8 mod

8281314: Rename Stack{Red,Yellow,Reserved,Shadow}Pages multipliers

Reviewed-by: stuefe, coleenp, xliu

-------------

PR: https://git.openjdk.java.net/jdk/pull/7362


More information about the hotspot-runtime-dev mailing list