RFR: 8281267: VM HeapDumper dumps array classes several times

Chris Plummer cjplummer at openjdk.java.net
Wed Feb 9 20:20:10 UTC 2022


On Tue, 8 Feb 2022 16:49:41 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> ClassLoaderDataGraph::classes_do description says:
> // Walking classes through the ClassLoaderDataGraph include array classes.
> So do_load_class callback should not dump arrays for the classes and dumper doesn't need to call Universe::basic_type_classes_do (array classes for primitive types are also reported by ClassLoaderDataGraph::classes_do)

src/hotspot/share/services/heapDumper.cpp line 2293:

> 2291:     // Writes HPROF_GC_CLASS_DUMP records
> 2292:     // For array classes we need signers and protection domain from their bottom classes
> 2293:     // so do_class_dump skips array classes and dumps array classes with corresponding instance class.

I'm having trouble parsing this comment. Can you clarify?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7384


More information about the hotspot-runtime-dev mailing list