RFR: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths

Aleksey Shipilev shade at openjdk.java.net
Thu Feb 10 07:08:06 UTC 2022


On Thu, 10 Feb 2022 04:53:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Please review this trivial fix for UL parsing logic on Windows. We already special-cased paths like c:\logfile but didn't allow for c:/logfile. As noted in the bug report this is a regression from using -Xloggc where the c:/ path was allowed (and it even worked when Xloggc was converted internally to use UL - because it skipped the parsing logic and just directly set the file output!).
> 
> Testing:
>   - new gtest added by expanding existing parsing gtest
>   - tiers 1-3 Windows
> 
> Verified that new gtest fails without the fix.
> 
> Thanks,
> David

Looks good.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7415


More information about the hotspot-runtime-dev mailing list