RFR: 8279949: JavaThread::_free_handle_block leaks native memory

[Coleen Phillimore]

On Sat, 12 Feb 2022 22:07:33 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Please review following fix which delete whole list of JNIHandle blocks in JNIHandleBlock::release_block(...).
> Also, I added sanity verification of _pop_frame_link to ensure that there are no leaks there.
> 
> Fix verified with tier1-6. Also, verified that memory leak is not reproduced anymore.
> 
> Thanks to Vladimir I.  for finding exact root cause of problem.

This looks good to me. Thank you for finding and fixing this!

src/hotspot/share/runtime/jniHandles.cpp line 388:

> 386:     block = NULL;
> 387:   } else {
> 388:     DEBUG_ONLY(block->set_pop_frame_link(NULL));

Can this also be an assert that the pop_frame_link is null ?

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7453