RFR: 8281822: serviceability/7170638/SDTProbesGNULinuxTest.java test fails on !DTRACE_ENABLED builds after JDK-8278423

[David Holmes]

On Tue, 15 Feb 2022 11:54:07 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> This reproduces in GHA in x86_32 mode.
> 
> Reproduces locally too:
> 
> 
> $ CONF=linux-x86-server-fastdebug make run-test TEST=serviceability/7170638/SDTProbesGNULinuxTest.java
> 
> java.lang.Error: java.lang.RuntimeException: '.note.stapsd' missing from stdout
> 
> at SDTProbesGNULinuxTest.testLibJvm(SDTProbesGNULinuxTest.java:76)
> at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
> at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
> at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
> 
> 
> The reason is that the new test now enables `DTraceMethodProbes`, `DTraceAllocProbes`, `DTraceMonitorProbes`, but VM never actually checks those options are available. So test thinks dtrace support is there, yet there are no relevant sections in `libjvm.so`, so the test fails. We should extend the argument checks to those three options too.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug (dtrace enabled), affected test still passes
>  - [x] Linux x86_32 fastdebug (dtrace disabled due to missing dependencies), affected test now passes

Looks good!

So JDK-8278423 exposed this pre-existing bug.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7477