Integrated: 8281822: Test failures on non-DTrace builds due to incomplete DTrace* flags handling

[Aleksey Shipilev]

On Tue, 15 Feb 2022 11:54:07 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> A test failure reproduces in GHA in x86_32 mode. Reproduces locally too:
> 
> 
> $ CONF=linux-x86-server-fastdebug make run-test TEST=serviceability/7170638/SDTProbesGNULinuxTest.java
> 
> java.lang.Error: java.lang.RuntimeException: '.note.stapsd' missing from stdout
> 
> at SDTProbesGNULinuxTest.testLibJvm(SDTProbesGNULinuxTest.java:76)
> at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
> at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
> at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
> 
> 
> The reason is that the new test now enables `DTraceMethodProbes`, `DTraceAllocProbes`, `DTraceMonitorProbes`, but VM never actually checks those options are available. So test thinks dtrace support is there, yet there are no relevant sections in `libjvm.so`, so the test fails. We should extend the argument checks to those three options too.
> 
> Unfortunately, there are tests that do `DTrace*` flags, we should make them sense the build capability, and act accordingly. This simplifies some existing tests too.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug (dtrace enabled), affected test still passes
>  - [x] Linux x86_32 fastdebug (dtrace disabled due to missing dependencies), affected test now passes

This pull request has now been integrated.

Changeset: 847a99b5
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/847a99b53da6b2c82f7cd5f8634aa7bbae8f445e
Stats:     144 lines in 9 files changed: 128 ins; 13 del; 3 mod

8281822: Test failures on non-DTrace builds due to incomplete DTrace* flags handling

Reviewed-by: dholmes, kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/7477