RFR: 8281543: Remove unused code/headerfile dtraceAttacher.hpp

David Holmes dholmes at openjdk.java.net
Sun Feb 20 22:13:47 UTC 2022


On Sat, 19 Feb 2022 10:15:15 GMT, Emanuel Peter <duke at openjdk.java.net> wrote:

> `dtraceAttacher.cpp` with all the relevant definitions was deleted [here](https://github.com/openjdk/jdk/commit/071bd521bca2485c6df95c45e4310d39b05bd046)
> in connection with [JDK-8244224](https://bugs.openjdk.java.net/browse/JDK-8244224) (Remove the Solaris and SPARC Ports).
> 
> I deleted `dtraceAttacher.cpp`, and the 4 include statements of it in 4 `src/hotspot/os/???/attachListener_???.cpp` files.
> 
> Ran tests, mostly to check that it still compiles on various platforms.

Hi Emanuel,

This looks good and trivial.

AFAICS the existence of these includes was a mistake in the first place. Only `attachListener_solaris.cpp` actually needed it, but a limitation of the ancient `includeDB` mechanism meant it was listed as needed by all `attachListener_<os_family>.cpp` files. Then when we got rid of `includeDB` and moved to the standard include mechanism, that dependency was expanded to produce an include entry in each file now being fixed.

Cheers,
David

-------------

PR: https://git.openjdk.java.net/jdk/pull/7544


More information about the hotspot-runtime-dev mailing list