RFR: 8280422: thread_from_jni_environment can never return NULL [v2]

[Johannes Bechberger]

On Mon, 21 Feb 2022 13:36:55 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/runtime/thread.hpp line 1327:
>> 
>>> 1325:     if (current->is_terminated()) {
>>> 1326:       current->block_if_vm_exited();
>>> 1327:       ShouldNotReachHere();
>> 
>> This breaks AsyncGetCallTrace
>
> If we reach that code then the VM aborts. It should be impossible to reach that statement and thus impossible to actually return NULL in the old code. Please elaborate under what conditions you think this code can be reached.

AsyncProfiler on a debug build of OpenJDK profiling the dacapo tomcat benchmark.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7193