RFR: JDK-8282345: handle latest VS2022 in abstract_vm_version
David Holmes
dholmes at openjdk.java.net
Thu Feb 24 23:03:13 UTC 2022
On Thu, 24 Feb 2022 12:30:40 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> Hi, please review this small VS-related change.
> The latest VS2022 versions should be handled in abstract_vm_version, e.g. 17.0, see
> https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170
> Additionally, very old VS versions can be removed from abstract_vm_version.
>
> Thanks, Matthias
Looks fine. Removing the old versions is not necessary but probably not harmful either.
I wonder if MS will ever provide an actual version string for their compilers so we don't have to do this every time they get updated.
Thanks,
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7606
More information about the hotspot-runtime-dev
mailing list