RFR: 8282360: Merge POSIX implementations of ThreadCritical

David Holmes dholmes at openjdk.java.net
Sat Feb 26 12:47:47 UTC 2022


On Fri, 25 Feb 2022 13:44:06 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this small change to merge the Posix (aix, bsd, linux) implementations of ThreadCritical into a single file named src/hotspot/os/posix/threadCritical_posix.cpp.  The change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
> 
> Thanks, Harold

Hi Harold,

The merge looks good.

The pre-existing use of PTHREAD_MUTEX_INITIALIZER is potentially problematic on FreeBSD - see comments in os_posix.cpp for mutexAttr. But that is a separate problem.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7622


More information about the hotspot-runtime-dev mailing list