[jdk18] RFR: 8272058: 25 Null pointer dereference defect groups in 4 files [v2]

Daniel D.Daugherty dcubed at openjdk.java.net
Tue Jan 4 20:32:06 UTC 2022


> A small refactoring to resolve a Parfait complaint about the return value from
> `MacroAssembler::target_addr_for_insn(address insn_addr, unsigned insn)`
> on AARCH64. The logic that supports returning `nullptr` as the target addr for
> a particular instruction is moved from
> `MacroAssembler::target_addr_for_insn(address insn_addr, unsigned insn)` to
> `MacroAssembler::target_addr_for_insn_allow_null_ret(address insn_addr, unsigned insn)`.
> A couple of `target_addr_for_insn()` call sites that can tolerate a `nullptr` are
> converted to use `target_addr_for_insn_allow_null_ret()`.
> 
> This fix has been tested with Mach5 Tier[1-3].

Daniel D. Daugherty has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into JDK-8272058
 - 8272058.exp1.patch

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk18/pull/51/files
  - new: https://git.openjdk.java.net/jdk18/pull/51/files/4c93290e..55ef47ff

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk18&pr=51&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk18&pr=51&range=00-01

  Stats: 1578 lines in 103 files changed: 1031 ins; 255 del; 292 mod
  Patch: https://git.openjdk.java.net/jdk18/pull/51.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/51/head:pull/51

PR: https://git.openjdk.java.net/jdk18/pull/51


More information about the hotspot-runtime-dev mailing list