RFR: 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure [v2]

[Gerard Ziemski]

On Tue, 4 Jan 2022 20:24:23 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> Thumbs up. You mentioned "Mach5" testing; I'm presuming Tier1 was
> done and passed.

Thank you Dan for the review!

I did tiers: 1,2,3,4,5

> test/hotspot/gtest/runtime/test_os.cpp line 368:
> 
>> 366:   // to figure out if that's supported on this macOS version
>> 367:   const bool executable = true;
>> 368:   size_t test_len = 128;
> 
> Just curious: since you made local var `executable` `const`, I have to wonder
> why you didn't make local var `test_len` `const`?

copy/paste consequence, did not meant to make it `const`, but copied the line from the existing code that used it. I will remove it.

> test/hotspot/gtest/runtime/test_os.cpp line 388:
> 
>> 386:     //  to prevent kernel from folding these mappings.
>> 387: #ifdef __APPLE__
>> 388:     const bool executable = exec_supported? (stripe % 2 == 0) : false;
> 
> Nit: please add a space before the `?` operator.

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6960