RFR: 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure

[Gerard Ziemski]

On Tue, 4 Jan 2022 19:18:45 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> Re-enable **release_multi_mappings** gtest on macOS
> 
> This test would occasionally fail on macOS, but thanks to Dan's catch, it turned out that it actually only fails on those test machines that run macOS 10.13.6 or earlier.
> 
> The proposed fix simply makes a single call to `os::reserve_memory()` with the `executable` flag `True`, and if that failed forces `executable`  to `False` later in the actual test code (alternatively we could have just also skipped that test portion completely, but this way we actually do something rather than nothing at all).
> 
> Tested manually on macOS 10.13.6 and via Mach5

Do I need a 2nd review? This is a test, but on the other hand we are getting pretty close to release?

If I don't get a 2nd review in the next couple of days, I will assume that I'm OK to check it in...

-------------

PR: https://git.openjdk.java.net/jdk/pull/6960