RFR: 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure [v4]
Gerard Ziemski
gziemski at openjdk.java.net
Thu Jan 6 16:16:55 UTC 2022
> Re-enable **release_multi_mappings** gtest on macOS
>
> This test would occasionally fail on macOS, but thanks to Dan's catch, it turned out that it actually only fails on those test machines that run macOS 10.13.6 or earlier.
>
> The proposed fix simply makes a single call to `os::reserve_memory()` with the `executable` flag `True`, and if that failed forces `executable` to `False` later in the actual test code (alternatively we could have just also skipped that test portion completely, but this way we actually do something rather than nothing at all).
>
> Tested manually on macOS 10.13.6 and via Mach5
Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
rename can_alloc_executable_memory to can_reserve_executable_memory
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/6960/files
- new: https://git.openjdk.java.net/jdk/pull/6960/files/f4bf7eba..5cbceaf8
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6960&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6960&range=02-03
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.java.net/jdk/pull/6960.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/6960/head:pull/6960
PR: https://git.openjdk.java.net/jdk/pull/6960
More information about the hotspot-runtime-dev
mailing list