RFR: 8277531: Print actual default stacksize on Windows thread logging [v2]

David Holmes dholmes at openjdk.java.net
Fri Jan 7 04:33:19 UTC 2022


On Mon, 27 Dec 2021 10:24:59 GMT, KIRIYAMA Takuya <duke at openjdk.java.net> wrote:

>> I modified to log actual stack size on Windows by using `os::win32::default_stack_size()`.
>> Could you please review this fix?
>
> KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - 8277531: Print actual default stacksize on Windows thread logging
>  - Merge branch 'master' into 8277531
>  - 8277531: Print actual default stacksize on Windows thread logging

I think adding the stacksize to the "thread is alive" log statement is a reasonable alternative approach. The JBS issue should be updated to reflect the change in approach. I don't think we need a new test for this but you could possibly add something to the existing ./runtime/logging/ThreadLoggingTest.java

-------------

PR: https://git.openjdk.java.net/jdk/pull/6495


More information about the hotspot-runtime-dev mailing list