RFR: 8261455: Automatically generate the CDS archive if necessary [v7]

[Ioi Lam]

On Mon, 10 Jan 2022 22:38:06 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> This patch is re-coded after serial fixes related: 8275846, 8276787, 8279018 etc.
>> original description(PR 5997):
>> `----------------------------------------------------------------------------------`
>> When shared archive (dynamic archive) failed to map due to damage of the archive file, dump/run jdk version mismatch or non-existence file etc, the new patch will automatically create a new shared archive if -XX:+AutoCreateSharedArchive specified with the name based on SharedArchiveFile.
>> This is a revised patch based on the old PR: 5077 and after bug 8273152 integrated.
>> `-----------------------------------------------------------------------------------`
>> 
>> Tests: tier1,tier2,tier3,tier4
>> 
>> Thanks
>> Yumin
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed edit error for last update, tested

Some test comments

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchive.java line 51:

> 49:  *
> 50:  *   10.01 run with non-existing archive should automatically create dynamic archive.
> 51:  *        If the JDK's default CDS archive cannot be loaded, print out warning, run continue without shared archive and no shared archive created at exit.

The test cases are called "10.01" here but "10.1" before. This makes it hard to do a text search. Could you make the numbering consistent?

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveNoDefaultArchive.java line 107:

> 105:         // Now rename classes.jsa to old-classes.jsa
> 106:         String dstDir = java_home_dst + File.separator + "lib" + File.separator + "server";
> 107:         CDSTestUtils.renameModulesFile(dstDir, "classes.jsa", "old-classes.jsa");

This API needs to be updated -- it doesn't rename the modules file. How about:


CDSTestUtils.rename(File fromFile, File toFile)

-------------

PR: https://git.openjdk.java.net/jdk/pull/6920