RFR: 8261455: Automatically generate the CDS archive if necessary [v2]

Ioi Lam iklam at openjdk.java.net
Tue Jan 11 00:08:25 UTC 2022


On Mon, 3 Jan 2022 07:36:35 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Set ArchiveClassesAtExit when AutoCreateSharedArchive is enabled
>
> src/hotspot/share/cds/filemap.cpp line 1132:
> 
>> 1130:       warning_continue("The shared archive file version %d which is not current version %d",
>> 1131:                                     gen_header._version, CURRENT_CDS_ARCHIVE_VERSION);
>> 1132:     }
> 
> There's no need to add `warning_continue`. `FileMapInfo::fail_continue` means:
> 
> - when running with -Xshare:auto, print a warning and continue
> - when running with -Xshare:on, print an error and exit
> 
> All other calls of `FileMapInfo::fail_continue` expects this behavior.

Grammar: should be

The shared archive file version %d does not match the required version %d

-------------

PR: https://git.openjdk.java.net/jdk/pull/6920


More information about the hotspot-runtime-dev mailing list