RFR: 8279970: two AppCDS tests fail after JDK-8261455

[Calvin Cheung]

On Thu, 13 Jan 2022 21:14:05 GMT, Yumin Qi <minqi at openjdk.org> wrote:

> Please review
>   The failure of the two tests is from jtreg run with -Xshare:off, the arguments caused confusion with the test cases. In fact they should be avoided to run with CDS is disabled.
> 
>   Tests: tier5 (in testing)
>              Manually repeat the test failure in local jtreg, and passed jtreg in local.
> 
> Thanks
> Yumin

Changes look okay. One suggestion below.

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchive.java line 128:

> 126:         if (isUseSharedSpacesDisabled()) {
> 127:             System.out.println("This test is not applicable when JTREG tests are executed with -Xshare:off, or if the JDK doesn't have a default archive.");
> 128:             return;

Suggestion: throw a `SkippedException` instead of `System.out.println`.

test/hotspot/jtreg/runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java line 108:

> 106:         if (isUseSharedSpacesDisabled()) {
> 107:             System.out.println("This test is not applicable when JTREG tests are executed with -Xshare:off, or if the JDK doesn't have a default archive.");
> 108:             return;

Same suggestion as above.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7070