RFR: JDK-8280019: Remove unused code from metaspace
Thomas Stuefe
stuefe at openjdk.java.net
Fri Jan 14 16:03:29 UTC 2022
On Fri, 14 Jan 2022 14:02:25 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> Sonarcloud-inspired code grooming. Trivial removal of unused code in metaspace.
> Change looks good but was any testing done for this change? Thanks, Harold
Hi Harold,
well, I manually built several configurations (x64, x86, release, fastdebug) and ran gtests. Beyond that, I would not have thought tests to be necessary since the removed coding was never used.
I also know this coding quite well since all I added it for JEP 387, so I am confident nothing vital was cut.
In GHAs, I see one failure on x86 where we crash in jdk/javadoc/doclet/testLinkPlatform/TestLinkPlatform.java
with "Overflow during reference processing", but that is unrelated to my change and also happens to others, see e.g. https://github.com/openjdk/jdk/pull/7059.
Thanks, Thomas
-------------
PR: https://git.openjdk.java.net/jdk/pull/7085
More information about the hotspot-runtime-dev
mailing list