RFR: 8277531: Print actual default stacksize on Windows thread logging [v3]
David Holmes
dholmes at openjdk.java.net
Mon Jan 17 05:59:21 UTC 2022
On Thu, 13 Jan 2022 11:49:06 GMT, KIRIYAMA Takuya <duke at openjdk.java.net> wrote:
>> I modified to log actual stack size on Windows by using `os::win32::default_stack_size()`.
>> Could you please review this fix?
>
> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
>
> 8277531: Print actual default stacksize on Windows thread logging
I'm okay with seeing this go ahead as-is. Please change the second copyright year from 2021 to 2022 in the source file and test file.
Arguably all platforms could include the stack size in this part of the logging, but I'm okay with just Windows for now. (I think there is room for sharing a lot of the thread startup logic on non-Windows, at which time I'd add the logging change.)
Thanks,
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6495
More information about the hotspot-runtime-dev
mailing list