[jdk18] RFR: 8272058: 25 Null pointer dereference defect groups in 4 files [v4]

Coleen Phillimore coleenp at openjdk.java.net
Tue Jan 18 22:03:25 UTC 2022


On Tue, 4 Jan 2022 20:41:36 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 293:
>> 
>>> 291: 
>>> 292: address MacroAssembler::target_addr_for_insn_allow_null_ret(address insn_addr, unsigned insn) {
>>> 293:   if (Instruction_aarch64::extract(insn, 31, 22) == 0b1011100101 &&
>> 
>> Consider replacing raw constants check with NativeInstruction::is_ldrw_to_zr function call which performs the same check.
>
> Good catch. There are actually two uses of the raw constants in
> macroAssembler_aarch64.cpp and I've cleaned up both.

This was a nice refactoring.

-------------

PR: https://git.openjdk.java.net/jdk18/pull/51


More information about the hotspot-runtime-dev mailing list