RFR: 8279009: CDS crashes when the source of an InstanceKlass is NULL [v2]

Yumin Qi minqi at openjdk.java.net
Tue Jan 18 23:34:21 UTC 2022


> Please review
>   When user combine -XX:ArchiveClassesAtExit and -XX:DumpLoadedClassList, vm will generate shared archive at exit mean while dump class list to a file, it will encounter null source when lambda form invoker holder classes are regenerated which have no source.  It failed to output the NULL source.
>    The fix is simply add ing check if the source exists. 
>    For unregistered classes loaded from shared space, they should be filtered out since the source are not recorded in shared space.
> 
>    Tests: tier2,tier2.tier3,tier4
> 
> Thanks
> Yumin

Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:

  Rename ClassListWithInvokerClassNoSource.java to ClassSpecializerTestApp.java with comments, remove code using asm

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7072/files
  - new: https://git.openjdk.java.net/jdk/pull/7072/files/5ed9f62d..fad5ae5b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7072&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7072&range=00-01

  Stats: 175 lines in 4 files changed: 68 ins; 81 del; 26 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7072.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7072/head:pull/7072

PR: https://git.openjdk.java.net/jdk/pull/7072


More information about the hotspot-runtime-dev mailing list