RFR: 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure [v7]

[Daniel D.Daugherty]

On Wed, 19 Jan 2022 16:19:58 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Re-enable **release_multi_mappings** gtest on macOS
>> 
>> This test would occasionally fail on macOS, but thanks to Dan's catch, it turned out that it actually only fails on those test machines that run macOS 10.13.6 or earlier.
>> 
>> The proposed fix simply makes a single call to `os::reserve_memory()` with the `executable` flag `True`, and if that failed forces `executable`  to `False` later in the actual test code (alternatively we could have just also skipped that test portion completely, but this way we actually do something rather than nothing at all).
>> 
>> Tested manually on macOS 10.13.6 and via Mach5
>
> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix comment

Thumb up. Feel free to ignore my nit about adding a period.

test/hotspot/gtest/runtime/test_os.cpp line 383:

> 381: #ifdef __APPLE__
> 382:   // Workaround: try reserving executable memory to figure out
> 383:   // if such operation is supported on this macOS version

Please add a period at the end of this sentence.

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6960