remove INCLUDE_NMT?

Aleksey Shipilev shade at redhat.com
Thu Jan 20 19:29:00 UTC 2022


On 1/20/22 3:58 PM, daniel.daugherty at oracle.com wrote:
> I think we need to hear from Zhengyu (original NMT author) and Aleksey Shiplev (he often fixes
> Minimal build failures). If this idea moves forward to a PR, then make sure the Build Team is
> included on the review. There maybe some unexpected complications there...

I am in favor of making NMT support unconditional.

I don't think anyone ships Minimal VMs for production use, or useds it for development. I build (and 
maintain the cleanliness of) Minimal VM as the smoke test: if a VM feature has a build-disabling 
flag, Minimal is likely to disable it, exposing the code incorrectly (non-)protected by INCLUDE_* 
defines. If a VM feature like NMT becomes unconditional, it does not break anything really, just one 
less optional path to take care of occasionally.

-- 
Thanks,
-Aleksey



More information about the hotspot-runtime-dev mailing list