RFR: 8279675: CDS cannot handle non-existent JAR file in bootclassapth

[Yumin Qi]

On Thu, 20 Jan 2022 20:21:39 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Non-existent boot class path and file with zero size won't be recorded during CDS dump time.
> This fix excludes checking of the above paths and files during runtime to avoid a false mismatch.
> 
> The proposed fix passed CI tiers 1-4 testing.

Looks good, I have two questions to be cleared.

src/hotspot/share/cds/filemap.cpp line 868:

> 866:       return true;   // ok, relaxed check, runtime has extra boot append path entries
> 867:     } else {
> 868:       ResourceMark rm;

Is the ResourceMark necessary here?

test/hotspot/jtreg/runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java line 225:

> 223:                 out.shouldNotContain(CLASS_FOUND_MESSAGE)
> 224:                    .shouldContain(OPTIMIZE_DISABLED)           // mapping info
> 225:                    .shouldContain("Error: Could not find or load main class .");

Is the fix changing the behavior for the test? Before fix, "." is seen as -Xbootclasspath/a:., but after fix, it is seen as 'main class'?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7169