RFR: 8278325: excluded class should not be checked again for exclusion

Yumin Qi minqi at openjdk.java.net
Wed Jan 26 03:57:41 UTC 2022


Hi, Please review

  When LambdaFormInvoker regenerate lambda form holder class, the old class with the same name already loaded and is marked for excluded for dump. This class should not be checked against exclusion, or it will output unexpected warning like:
[0.394s][warning][cds] Skipping java/lang/invoke/BoundMethodHandle$Species_J: Unsupported location
[0.394s][warning][cds] Skipping java/lang/invoke/BoundMethodHandle$Species_JL: Unsupported location
[0.394s][warning][cds] Skipping java/lang/invoke/BoundMethodHandle$Species_FL: Unsupported location
[0.394s][warning][cds] Skipping java/lang/invoke/BoundMethodHandle$Species_F: Unsupported location
  The fix changed the order for checking exclusion of a class --- only check for those that have not been set for exclusion. Original function DumpTimeClassInfo::is_excluded in fact is checking three conditions in logical OR, it does not tell which reason for exclusion. In this fix, we need check the exact reason which is set for _excluded. Original is_excluded is renamed to should_be_excluded.

Tests: tier1,tier4 (in testing)

Thanks
Yumin

-------------

Commit messages:
 - 8278325: excluded class should not be checked again for exclusion

Changes: https://git.openjdk.java.net/jdk/pull/7225/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7225&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8278325
  Stats: 38 lines in 4 files changed: 23 ins; 0 del; 15 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7225.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7225/head:pull/7225

PR: https://git.openjdk.java.net/jdk/pull/7225


More information about the hotspot-runtime-dev mailing list