RFR: JDK-8280004: DCmdArgument<jlong>::parse_value() should handle NULL input [v2]

[Matthias Baesken]

On Thu, 27 Jan 2022 09:18:06 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Hi,
>> 
>> may I have eyes please on this simple fix (Sonarcloud-inspired) which sanitizes the error output of DCmdArgument<jlong>::parse_value():
>> - since the input can be NULL, we should handle NULL
>> - we also limit parroting of invalid input to 64 chars max
>> - we also do not need a temporary RA buffer to assemble the output
>> 
>> Example output with patch, first a short, then a long invalid numeric parameter:
>> 
>> 
>> thomas at starfish:~$ jcmd Simple GC.class_histogram -parallel=hallo
>> 399746:
>> java.lang.IllegalArgumentException: Integer parsing error in command argument '-parallel'. Could not parse: "hallo".
>> thomas at starfish:~$ jcmd Simple GC.class_histogram -parallel=hallo012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
>> 399746:
>> java.lang.IllegalArgumentException: Integer parsing error in command argument '-parallel'. Could not parse: "hallo01234567890123456789012345678901234567890123456789012345678...".
>> 
>> 
>> Thanks, Thomas
>
> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - remove quotes to avoid disturbing parsing tests
>  - Merge
>  - sanitize error message

Marked as reviewed by mbaesken (Reviewer).

I think you might need to adjust the copyright year in the file;  but otherwise it's fine,

-------------

PR: https://git.openjdk.java.net/jdk/pull/7079