RFR: JDK-8280004: DCmdArgument<jlong>::parse_value() should handle NULL input

[Thomas Stuefe]

On Tue, 18 Jan 2022 07:03:26 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Hi,
>> 
>> may I have eyes please on this simple fix (Sonarcloud-inspired) which sanitizes the error output of DCmdArgument<jlong>::parse_value():
>> - since the input can be NULL, we should handle NULL
>> - we also limit parroting of invalid input to 64 chars max
>> - we also do not need a temporary RA buffer to assemble the output
>> 
>> Example output with patch, first a short, then a long invalid numeric parameter:
>> 
>> 
>> thomas at starfish:~$ jcmd Simple GC.class_histogram -parallel=hallo
>> 399746:
>> java.lang.IllegalArgumentException: Integer parsing error in command argument '-parallel'. Could not parse: "hallo".
>> thomas at starfish:~$ jcmd Simple GC.class_histogram -parallel=hallo012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
>> 399746:
>> java.lang.IllegalArgumentException: Integer parsing error in command argument '-parallel'. Could not parse: "hallo01234567890123456789012345678901234567890123456789012345678...".
>> 
>> 
>> Thanks, Thomas
>
> Thanks Thomas! I was too focused on the original string and didn't check that the exception code was going to make a copy anyway. There's likely multiple copies made on the way to the final String object.

Thanks @dholmes-ora and @MBaesken !

-------------

PR: https://git.openjdk.java.net/jdk/pull/7079