RFR: 8289257: Some custom loader tests failed due to symbol refcount not decremented [v2]
Calvin Cheung
ccheung at openjdk.org
Fri Jul 1 02:13:32 UTC 2022
> Removing the test for class loader name symbol refcount since similar test exists in runtime/ClassUnload/UnloadTest.java.
>
> Tested locally on linux-x64 with ZGC. Running more tests via mach5.
>
> An alternative approach would be adding a `WB.fullGC()` call after `ClassUnloadCommon.triggerUnloading()` as follows:
>
>
> --- a/test/hotspot/jtreg/runtime/cds/appcds/customLoader/test-classes/HelloUnload.java
> +++ b/test/hotspot/jtreg/runtime/cds/appcds/customLoader/test-classes/HelloUnload.java
> @@ -105,6 +105,7 @@ public class HelloUnload {
>
> urlClassLoader = null; c = null; o = null;
> ClassUnloadCommon.triggerUnloading();
> + wb.fullGC();
> System.out.println("Is CustomLoadee alive? " + wb.isClassAlive(className));
> ClassUnloadCommon.failIf(wb.isClassAlive(className), "should have been unloaded");
Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
remove System.currentTimeMillis() from class loader name
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/9340/files
- new: https://git.openjdk.org/jdk/pull/9340/files/a963936c..cbd63cdb
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=9340&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=9340&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/9340.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9340/head:pull/9340
PR: https://git.openjdk.org/jdk/pull/9340
More information about the hotspot-runtime-dev
mailing list