RFR: JDK-8288824: [arm32] Display isetstate in register output

Dmitry Samersoff dsamersoff at openjdk.org
Tue Jul 5 09:11:33 UTC 2022


On Tue, 5 Jul 2022 08:47:21 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/os_cpu/linux_arm/os_linux_arm.cpp line 459:
>> 
>>> 457:   case 2: st->print_cr("Jazelle"); break;
>>> 458:   case 3: st->print_cr("ThumbEE"); break;
>>> 459:   default: ShouldNotReachHere();
>> 
>> Should we print here something like "undefined" rather than abort VM?
>
> Hi Dmitry,
> 
> I think this cannot happen, since isetstate is the combination of two bits (see line 451 ff). So an assert would be correct here, since this can only fire if we break that assumption by changing isetstate with a future patch.
> 
> But I am unemotional. If you prefer not to assert, I can use "undefined".
> 
> Cheers, Thomas

Thank you for the explanation. I'm OK with current changes.

-------------

PR: https://git.openjdk.org/jdk/pull/9223


More information about the hotspot-runtime-dev mailing list