[jdk19] RFR: 8290004: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC

Lutz Schmidt lucy at openjdk.org
Mon Jul 11 09:08:00 UTC 2022


On Fri, 8 Jul 2022 11:14:14 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> We must read last_Java_sp first memory ordering wise. Otherwise, last_Java_pc can be 0.
> Note: Writer side already uses release semantics, see javaFrameAnchor_ppc.hpp.
> 
> Setting pc to `*(sp + 2)` is no longer needed. Frame constructor does that in `setup()`.

Changes look good to me. 
Thanks for fixing.
Lutz

-------------

Marked as reviewed by lucy (Reviewer).

PR: https://git.openjdk.org/jdk19/pull/124


More information about the hotspot-runtime-dev mailing list