RFR: 8289003: JavaThread::check_is_terminated() implementation should rely on Thread-SMR

[David Holmes]

On Thu, 14 Jul 2022 21:50:04 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> A small fix to change `JavaThread::check_is_terminated()` to rely on Thread-SMR.
> The change is textually trivial, but requires a bit of thinking about the JavaThread
> lifecycle. Since this is a cleanup of some old Thread-SMR related changes, I also
> took the time to cleanup some comments and white space while I was visiting the
> uses of `_vm_exited`.
> 
> Mach5 Tier1 has no related failures. Mach5 Tier[23] testing has just started.

Looks fine.

Thanks,
David

src/hotspot/share/runtime/javaThread.hpp line 571:

> 569:   bool is_oop_safe() const;
> 570:   // thread is terminated (no longer on the threads list); the thread must
> 571:   // protected by a ThreadsListHandle to avoid potential crashes.

// be protected ...

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9502