RFR: 8290324: Move atomic operations outside of os_xxx.hpp
David Holmes
dholmes at openjdk.org
Fri Jul 15 06:18:02 UTC 2022
On Thu, 14 Jul 2022 21:38:58 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> The os_xxx.hpp files inject extra methods/fields that are specific to atomic operations into the `os` class. However, the injected methods/fields are used only by a specific os/cpu combination. Therefore, they should not be inside the `os` class, which should contain only APIs that are used across platforms.
>
> - For ports where the `atomic_copy64()` function is used in a single file, I moved it as an inline function in that file
> - Otherwise it's moved to `atomic_<os>_<cpu>.hpp`
> - The linux/arm port is a little more involved, but the new code should be a little cleaner than the old code.
Seems okay - good cleanup.
I'm okay with it if Aarch64 folk are.
Thanks.
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9501
More information about the hotspot-runtime-dev
mailing list