RFR: 8290324: Move atomic operations outside of os_xxx.hpp [v3]
David Holmes
dholmes at openjdk.org
Tue Jul 19 05:28:43 UTC 2022
On Mon, 18 Jul 2022 21:49:54 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> The os_xxx.hpp files inject extra methods/fields that are specific to atomic operations into the `os` class. However, the injected methods/fields are used only by a specific os/cpu combination. Therefore, they should not be inside the `os` class, which should contain only APIs that are used across platforms.
>>
>> - For ports where the `atomic_copy64()` function is used in a single file, I moved it as an inline function in that file
>> - Otherwise it's moved to `atomic_<os>_<cpu>.hpp`
>> - The linux/arm port is a little more involved, but the new code should be a little cleaner than the old code.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>
> @kimbarrett comments: cleaned up ARMAtomicFuncs; added "static inline". Also removed os:: from C_frame_offset on linux/arm.
Still okay. But I would have resisted making non-move-related changes and leave that for future cleanups.
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9501
More information about the hotspot-runtime-dev
mailing list